[Bug 190502] Review Request: sportstracker

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sportstracker


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190502


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |jpmahowald at gmail.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From jpmahowald at gmail.com  2006-05-28 12:17 EST -------
When first started, it gives a fatal looking error, "Failed to load application
data! Starting with empty lists.
See console output for more informations."

Creation of a sport type made it go away on the next startup, however. I assume
this happens with SportsTracker itself.

* debuginfo package is empty, should be disabled, like how I mention in the new
hint from the mono packaging tips: http://fedoraproject.org/wiki/Packaging/Mono

* README.txt has potentially useful information, though the install information
is not relevant. Consider including, and possibly the other docs.

- rpmlint checks return:
E: sportstracker hardcoded-library-path in %{_prefix}/lib/%{name}/
A library path is hardcoded to one of the following paths: /lib,
/usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}.

The usual hack to get it to install to /usr/lib on x86_64. Another way of doing
it is to redefine %_libdir but I don't think there's a preference.

E: sportstracker no-binary
The package should be of the noarch architecture because it doesn't contain
any binaries.

Yet it installs to %_libdir.

E: sportstracker only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.

mono stuff is in /usr/lib. Ignore.

- naming guidelines: capitalization. Authors call it SportsTracker. If they
insist on the capitalization it should be SportsTracker.

- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- locales handled with %find_lang
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- consider submitting .desktop file to SportsTracker



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.