[Bug 203864] Review Request: tripwire - IDS

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tripwire - IDS


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864





------- Additional Comments From rpm at greysector.net  2006-11-01 15:30 EST -------
(?)1. package meets naming and packaging guidelines.

Release:        1%{?dist}.4

This should be:
Release:        4%{?dist}

2. specfile is properly named, is cleanly written and uses macros consistently.
3. dist tag is present.
4. build root is correct.
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
5. license field matches the actual license.
6. license is open source-compatible (GPL). License text included in package.
7. source files match upstream:
b371f79ac23cacc9ad40b1da76b4a0c4  tripwire-2.4.0.1-src.tar.bz2
8. latest version is being packaged.
9. BuildRequires are proper.
(?)10. package builds in mock ( ).
11. rpmlint is silent.
(?)12. final provides and requires are sane:
config(tripwire) = 2.4.0.1-1.4
tripwire = 2.4.0.1-1.4
=
config(tripwire) = 2.4.0.1-1.4
gawk
grep
gzip
libcrypto.so.6()(64bit)
libgcc_s.so.1()(64bit)
libm.so.6()(64bit)
libstdc++.so.6()(64bit)
sed
tar

What is
Requires: sed grep gzip tar gawk
needed for?

13. no shared libraries are present.
14. package is not relocatable.
15. owns the directories it creates.
16. doesn't own any directories it shouldn't.
17. no duplicates in %files.
(?)18. file permissions are appropriate.
%attr(0755,root,root) %dir %{_sysconfdir}/tripwire
possibly, this should be 0700
19. %clean is present.
20. %check is not present
(?)21. scriptlets are ok
Requires(post): sed
is missing.
Also, don't print anything in %post.
22. code, not content.
23. documentation is small, so no -docs subpackage is necessary.
24. %docs are not necessary for the proper functioning of the package.
25. no headers.
26. no pkgconfig files.
27. no libtool .la droppings.
28. not a GUI app.
29. not a web app.

Please take care of 1, 12, 18 and 21 while I build it in mock.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.