[Bug 209311] Review Request: espeak - Software speech synthesizer (text-to-speech)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: espeak - Software speech synthesizer (text-to-speech)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209311





------- Additional Comments From faucamp at csir.co.za  2006-11-02 13:43 EST -------
Thanks for the feedback! 

New build:
Spec URL: http://dialogpalette.sourceforge.net/extras/fedora/espeak.spec
SRPM URL: http://dialogpalette.sourceforge.net/extras/fedora/espeak-1.16-2.src.rpm

Changes:
- Added "install" target to makefile (makefile_install_target.patch)
- Added patch to fix AMD64 sizeof(char *) assumption bug (upstream request ID
1588938)
- Changed "portaudio" BuildRequires to "portaudio-devel"
- Added patch to makefile to allow RPM_OPT_FLAGS
- Added patch to replace all references to "speak" binary with "espeak"
- Moved header files to /usr/include/espeak

A few comments:
Development headers: As mentioned in the ReadMe, the speak_lib.h provides the
entire API to the libespeak shared library, and it references no other
espeak-specific headers, so it is unecessary to include any other .h files. 

Binary voice data: The espeak program itself (formerly "speak" ;-) ) cannot
compile the binary voice data (using the --compile arg) from source without a
binary version of the phoneme tables being present. These phoneme table data
files cannot be compiled from source using espeak/speak; they are compiled with
a seperate program, "espeakedit", which is an interactive, GUI-based editing
tool, also released under the GPL. There is no explicit license file for the
binary voice data/phoneme tables, but since the source from which these are
compiled is under the GPL, I don't think there are any legal problems.

Patches: Depending on the feedback from this package build, I will push the
makefile patches upstream (except for the RPM_OPT_FLAGS patch). 

espeak name: I agree that the "speak" name is troublesome, and have removed it
from this rpm, as per suggestion. However, we must remember that some other
applications may already be using eSpeak via the "speak" executable (especially
since the shared library is a relatively new addition to espeak); this patch may
break compatability with such programs. Some HOWTO's and guides on the Internet
will also be (very slightly) incompatible with this naming scheme. There are
ways around this, naturally, but I'm uncertain whether changing the name in the
Fedora package is the best course of action. Nevertheless, depending on the
feedback here, I will push upstream for the name change... :-)

I've built this package in mock on FC6/i386. rpmlint is silent, except for the
no-documentation stuff for the -devel subpackage.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.