[Bug 212836] Review Request: fwfstab - a graphical file system table (fstab) editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fwfstab - a graphical file system table (fstab) editor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212836


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From panemade at gmail.com  2006-11-02 23:54 EST -------
Review:
+ package builds in mock (development i386) for FC6.
+ rpmlint is silent for RPM and SRPM.
+ source files match upstream.
fb87e760037a9497b1e8f47c8715e65d  fwfstab-0.01.1.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written but NOT properly indented.
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.  License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ COPYING included in %doc.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc files.
+ no -devel subpackage exists
+ no .la files.
+ no translations available
+ Provides: config(fwfstab) = 0.01.1-1.fc6
+ Requires: /bin/bash
            /usr/bin/python
            config(fwfstab) = 0.01.1-1.fc6
            pygtk2
            pygtk2-libglade
            python(abi) = 2.4
            redhat-artwork
            usermode


+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Desktop file installed succesfully
+ Desktop file is handled correclty in SPEC file.
+ GUI app
+ Followed python packaging guidelines.
APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.