[Bug 214227] Review Request: vala - A modern programming language for GNOME

bugzilla at redhat.com bugzilla at redhat.com
Mon Nov 6 19:27:10 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vala - A modern programming language for GNOME


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214227


jeff at ocjtech.us changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From jeff at ocjtech.us  2006-11-06 14:26 EST -------
* source files match upstream
ec3c9b717c49bd4fb207d368fe296475  vala-0.0.5.tar.bz2
ec3c9b717c49bd4fb207d368fe296475  vala-0.0.5.tar.bz2.1
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development & fc6, i386).
* package installs properly.  Sample code from home page builds and executes
properly.
* rpmlint has only acceptable complaints.
W: vala-devel no-documentation
* %check is not present; There is some test code in the distribution but no
framework to actually run the tests.
* shared libraries are present; ldconfig is called properly.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers are in the -devel subpackage.
* unversioned .so file is in the -devel subpackage.
* pkconfig file in in the -devel subpackage
* no libtool .la droppings.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list