[Bug 212923] Review Request: php-pear-XML-RSS - RSS parser

bugzilla at redhat.com bugzilla at redhat.com
Tue Nov 7 19:20:32 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-XML-RSS - RSS parser
Alias: pear-XML-RSS

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212923





------- Additional Comments From Fedora at FamilleCollet.com  2006-11-07 14:20 EST -------
REVIEW:
* Source XML_RSS-0.9.10.tgz is the same as upstream
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible (PHP License).
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* Builds fine in mock (development).
* package installs properly
* rpmlint 
W: php-pear-XML-RSS no-documentation
* final provides are sane:
php-pear(XML_RSS) = 0.9.10
php-pear-XML-RSS = 0.9.10-1.fc7
* %check is not present; 
* owns the directories it creates (XML own by php-pear)
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear install)
* code, not content.
* no documentation

SHOULD :
- requires other extensions with minimal version (php-pear(XML_Parser) >= 1.0.1)
- Add the PHP license in the %doc


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list