[Bug 213832] Review Request: arpwatch - Network monitoring tools for tracking IP addresses on a network

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: arpwatch - Network monitoring tools for tracking IP addresses on a network


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213832





------- Additional Comments From mlichvar at redhat.com  2006-11-10 07:37 EST -------
(In reply to comment #10)
> As you require /usr/sbin/sendmail you should probably also BuildRequire it
> because otherwise the /usr/lib/sendmail default from the configure script will
> be used.

Ok.

> The snmpwalk non-requirement looks to me like a non issue because user running
> the arpfetch command will get a message snmpwalk not found if it is not there.
> And I wouldn't say that the script is non functional, it just requires
> installation of another package.

I moved the arpfetch to %doc in the 1.1 release.

> The release number should be probably just a single number (+ disttag) for FC
devel.

Yes, I have used the minor number just for this reviewing process.

(In reply to comment #11)
> > The scripts aren't one-to-one copy of the scriptlets from guidelines but I don't
> > think it is mandatory to have one-to-one copy if they work the same.
> 
> I agree on the principle, but I'd like to have some explanations.
> Is it true that they work the same? Is it sure that the exit 0 is enough
> to avoid any failure? Some snippets on the wiki page have ||:, is it 
> unusefull?

rpm checks return code of the program executing the scriptlet, /bin/sh in this
case, and exit 0 guarantees it will return 0. This is the same as adding "||:"
to the last command in the script.

> * why isn't the useradd only done for the first install?

- the user may get deleted after first install or there could be an upgrade from
a broken/ancient version of arpwatch and arpwatch doesn't even start without the
user (with default config)
- other packages do the same

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.