[Bug 213600] Review Request: tinyca2 - Simple graphical userinterface to manage a small CA

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tinyca2 - Simple graphical userinterface to manage a small CA


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213600


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-11-10 11:48 EST -------
NOTE:
* would you consider using braces {} for using macro? I think
  using braces should make spec file easier to read......

Well,
1. From http://fedoraproject.org/wiki/Packaging/Guidelines :
* License
  - (NOT A BLOCKER) original tarball does not include the copy of
  GPL license. You should ask upstream to include GPL copy.

* Desktop files
  - For desktop-file-install, the line
    "--add-category X-Fedora" should be removed as
    * this is of no use any longer.
    * original desktop-file-utils 0.11 refuses this (although Fedora
      patched against this to only warn against this).
    See:
    http://fedoraproject.org/wiki/PackagingDrafts/DesktopFiles

2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
   = Nothing

3. Other things I have noticed :
* desktop file
  - (NOT A BROCKER) I strongly recommend that you install a 
    icon which can be used for desktop entry and write to 
    the spec file where (or how) we can get the icon. However,
    for a quick look I cannot find a proper icon from
    http://tinyca.sm-zone.net/ ....

    Would you ask upstream to provide a icon?

Consider the comments above. However I can approve this
package now.

----------------------------------------------------------
  This package (tinyca2) is APPROVED by me.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.