[Bug 190344] Review Request: vdr-osdteletext - OSD teletext plugin for VDR

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vdr-osdteletext - OSD teletext plugin for VDR


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190344


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |kevin at tummy.com
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From kevin at tummy.com  2006-11-12 00:10 EST -------
I agree with the above comments that having a easy link to the .spec file 
is a good thing and helps reviewers. 

That said, here's a review of this package: 

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
52c219e38a089504071237209ad114cd  vdr-osdteletext-0.5.1.tgz
52c219e38a089504071237209ad114cd  vdr-osdteletext-0.5.1.tgz.1
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
x86_64/i386 - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version

Issues:

1.  rpmlint says:

E: vdr-osdteletext non-standard-uid /var/cache/vdr/osdteletext vdr
W: vdr-osdteletext dangerous-command-in-%preun rm

Can both be ignored. Would be nice to get rid of the rm, but it
looks to be the same perl-Template issue that vdr had, so there isn't
a way around it. ;(

I don't see any blockers, so this package is APPROVED.

Don't forget to close this bug NEXTRELEASE once it's been imported
and built.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.