[Bug 215169] Review Request: xfce4-dict-plugin - A XFCE panel plugin to query a Dict server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-dict-plugin - A XFCE panel plugin to query a Dict server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215169





------- Additional Comments From fedora at christoph-wickert.de  2006-11-12 08:52 EST -------
Thanks for reviewing this so quickly. I was to tired yesterday to reply.

(In reply to comment #1)

> 1. Should add a:
> %defattr(-,root,root,-)
> to files?

Of course. I have no idea how I managed to delete this line...

> 2. Should the BuildRequire for xfce4-panel-devel 4.3.99.1 be 4.3.99.2,
> since everything else is requiring that version?

No, that's intentional, cause this is what ./configure checks for.

> checking for libxfcegui4-1.0 >= 4.3.90.2... 4.3.99.1
> ...
> checking for libxfce4util-1.0 >= 4.3.90.2... 4.3.99.1
> ...
> checking for libxfce4panel-1.0 >= 4.3.99.1... 4.3.99.1

I usually make the BuildRequires: as low as possible (to make the packages
easier to rebuild) but the Requires: to the version the plugin was compiled for.

Updated Package:
* Sun Nov 12 2006 Christoph Wickert <fedora christoph-wickert de> - 0.2.0-2
- Add %%defattr (#215169).

SPREC:
http://home.arcor.de/christoph.wickert/fedora/extras/review/SPECS/xfce4-dict-plugin.spec
SRPM: 
http://home.arcor.de/christoph.wickert/fedora/extras/review/SRPMS/xfce4-dict-plugin-0.2.0-2.fc7.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.