[Bug 212715] Review Request: openvrml - VRML/X3D runtime library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openvrml - VRML/X3D runtime library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212715





------- Additional Comments From braden at endoframe.com  2006-11-13 16:26 EST -------
(In reply to comment #6)
> I'm interested in having this in Extras, too. A few comments:
> 1. redundant BuildRequires: pkgconfig (required by freetype-devel and
> libpng-devel), libpng-devel (required by cairo-devel, which is required by
> gtk2-devel), fontconfig-devel (required by cairo-devel), freetype-devel
> (required by fontconfig-devel)

Okay. Presumably making openvrml-devel Require freetype-devel would moot Ralf's 
suggestion that openvrml-devel should Require pkgconfig.

> 2. use BuildRequires: gecko-devel instead of firefox-devel and libGLU-devel
> instead of mesa-libGLU-devel

Re: gecko-devel, I don't think I can do that. I think the change that does need 
to be made is for openvrml to Require firefox = 1.5.0.8. Note that libopenvrml 
links with libmozjs, which lives in a versioned subdirectory. Consequently, 
openvrml-devel would Require firefox-devel = 1.5.0.8.

> 3. reduntant Requires: mesa-libGLU for -gl subpackage

Why is that redundant?

> 4. use %setup -q instead of %setup
> 5. use %configure --disable-dependency-tracking to speed up build process
> 6. use %{__make} instead of make in %install for consistency

Okay.

> 7. avoid unnecessary docs duplication in every subpackage

Users shouldn't need to be aware of the package dependency chain in order to 
find the README or license for the package. Would it be acceptable to install 
symlinks?

> 8. rename mozilla-plugin to plugin

No. There are lots of kinds of plug-ins. This package makes a Mozilla/Gecko 
one. I might entertain changing it to "gecko-plugin"; but since "Mozilla plug-
in" or "Netscape plug-in" is what everyone calls these things, that's going to 
be a tough sell.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.