[Bug 209260] Review Request: beryl-manager - Beryl window decorator and theme management utility
bugzilla at redhat.com
bugzilla at redhat.com
Tue Nov 14 21:43:27 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: beryl-manager - Beryl window decorator and theme management utility
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209260
mr.ecik at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody at fedoraproject.org |mr.ecik at gmail.com
OtherBugsDependingO|163776 |163779
nThis| |
------- Additional Comments From mr.ecik at gmail.com 2006-11-14 16:43 EST -------
MUST items:
* rpmlint is quiet
* package is named well
* spec file name is good
* package meets Packaging Guidelines
* package is licensed with a GPL open-source compatible license
* License field in spec file matches actual license
* license file is included in %doc
* md5sums are matching (50c0235d59369674827ceaec7d36e53b)
* package successfully compiles on x86_64
* BuildRequires listed well (mock builds succesfully)
* spec file handles locales properly
* no need to %post and %postun sections
* not relocatable
* package owns directories well
* no duplicates in %files
* every %files section includes %defattr
* proper %clean section
* macros used well
Package looks almost well.
I haven't checked the another beryl packages yet, but you
use Provides: beryl in beryl-core package and here you're using
Requires: beryl-core. Maybe Requires: beryl would be better?
And the another thing: if a normal user type `yum install beryl`,
he won't get working beryl environment. He'll get only a beryl-core
package which alone is useless. Maybe you should create dependencies
differently to make possibility to install all essential beryl packages
by simply typying `yum install beryl`? How do you think?
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list