[Bug 198562] Review Request: zabbix - Open-source monitoring solution for your IT infrastructure

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: zabbix - Open-source monitoring solution for your IT infrastructure


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198562





------- Additional Comments From jeff at ocjtech.us  2006-11-16 12:26 EST -------
* source files match upstream
8e733e41506dd34759daba01deeeefd9  zabbix-1.1.4.tar.gz
8e733e41506dd34759daba01deeeefd9  zabbix-1.1.4.tar.gz.1
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (fc6 i386).
* package installs properly. 
* rpmlint says:

E: zabbix non-standard-uid /var/run/zabbix zabbix
E: zabbix non-standard-gid /var/run/zabbix zabbix
E: zabbix non-standard-uid /var/log/zabbix zabbix
E: zabbix non-standard-gid /var/log/zabbix zabbix
E: zabbix-agent non-standard-uid /var/log/zabbix zabbix
E: zabbix-agent non-standard-gid /var/log/zabbix zabbix
E: zabbix-agent non-standard-uid /var/run/zabbix zabbix
E: zabbix-agent non-standard-gid /var/run/zabbix zabbix

Can be ignored.

E: zabbix-web script-without-shebang /usr/share/zabbix/include/locales/pt_br.inc.php

! fix in %prep with %{__chmod} a-x frontends/php/include/locales/pt_br.inc.php

E: zabbix-web wrong-script-end-of-line-encoding
/usr/share/zabbix/include/locales/pt_br.inc.php

! fix in %prep with %{__sed} -i 's/\r//' frontends/php/include/locales/pt_br.inc.php

* %check is not present; There is no test code in the districution.
* no shared libraries are present
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers
* no unversioned .so file
* no pkconfig file
* no libtool .la droppings.

There should be:

Requires(pre): /usr/sbin/useradd

for both the main package and the agent package.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.