[Bug 203864] Review Request: tripwire - IDS

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tripwire - IDS


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203864





------- Additional Comments From rpm at greysector.net  2006-11-19 15:55 EST -------
Builds fine in devel/x86_64 mock.

Some more issues:

BuildRequires: autoconf seems to be unnecessary. Was there any reason to have it?

Could you remove that:
# Print getting started help message                                           
                                        
if [ $1 -eq 1 ]; then                                                          
                                        
        %{__cat} %_docdir/%{name}-%{version}/README.RPM                        
                                        
fi
from %post and (optionally) rename README.RPM to README.Fedora?

Additionally, you can change %defattr to read:
%defattr(644,root,root,755)
and remove %attr(644,root,root) from some files below.

I'm also unsure if %dir %{_var}/lib/tripwire/report should be readable by
everyone. Or maybe %{_var}/lib/tripwire, too. After all, I think only root will
be using tripwire, as it needs access to all files.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.