[Bug 217066] Review Request: python-gpod - A python module to access iPod content

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-gpod - A python module to access iPod content
Alias: python-gpod-review

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217066





------- Additional Comments From tmz at pobox.com  2006-11-25 00:23 EST -------
Thanks Jef.

I understand the points about using sed and rm and I did consider the
alternatives.  I'm not tied to either method so if there's a preference to do it
one way or the other, I'll change it to be more consistant with other FE packages.

My reasoning went like this:

Both the sed removal of the bang in gtkpod.py and the chmod of the example
scripts were needed to fix things rpmlint would complain about, so it seemed
better to do them both in the same place than to put one into a patch that
others would have to check out separately.

Using rm instead of %excludes seems cleaner looking to me since it's such a
wholesale removal.  I did use the info from the %files section of the core
libgpod package, so perhaps it'd be just as correct to modify those entries into
%excludes.

Like I said, I'm not tied to either method so if there's a preference for FE
packages I'll change to match that.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.