[Bug 216130] Review Request: glest - 3D real time strategy game

bugzilla at redhat.com bugzilla at redhat.com
Mon Nov 27 00:43:12 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: glest - 3D real time strategy game
Alias: glest

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216130


chris.stone at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From chris.stone at gmail.com  2006-11-26 19:42 EST -------
==== REVIEW CHECKLIST ====
- rpmlint output clean
- package named according to package naming guidelines
- spec file name matches %{name}
- package meets packaging guidelines
- licensed with open source compatible license
- license matches actual license
- license file included in %doc
- spec written in American english
- spec legible
- sources match upstream
f7716da7a044dbe108c619b0f52621bb  glest_source_2.0.0.zip
- successfully compiles and builds on FC6 x86_64
- all build dependencies listed in BR
- no locales
- no shared libraries
- package is not relocatable
- package owns all directories it creates
- directories it does not create owned by filesystem
- no duplicates in %files
- file permissions set properly
- package contains proper %clean section
- macro usage consistent
- contains code
- no large documentation
- files in %doc do not affect runtime
- no header files or static libraries
- no pkgconfig files
- no need for a devel subpackage
- no .la files
- GUI app contains proper .desktop file
- package does not own files or directories owned by other packages

APPROVED

==== SHOULD ====
- Add punctuation to %description.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list