[Bug 174377] Review Request: gnu-smalltalk - GNU Smalltalk
bugzilla at redhat.com
bugzilla at redhat.com
Tue Nov 28 07:22:02 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gnu-smalltalk - GNU Smalltalk
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174377
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2006-11-28 02:22 EST -------
Okay, I will review this package.
0. spec file description :
* %prep
- applying patches
I usually recommend to add some suffix every time you apply
a patch, e.g.
%patch1 -p1 -b .am
* %build section
- export CFLAGS="$RPM_OPT_FLAGS"
This is not necessary because %configure macro sets this.
- make %{?_smp_mflags} LIBTOOL="/usr/bin/libtool"
Use macro. i.e. LIBTOOL="%{_bindir}/libtool"
* %install section
- Fix broken Shebangs
(Please see "timestamp" section below for this).
* %files section
- COPYING
Why does every subpackage have same COPYING file? Only for
rpmlint issue? If so, please remove these as this rpmlint can be
ignored.
- *.st files
Well, actually I first saw this utility so I don't quite know
how to use this package, however, are these *.st really required
for 'minimal' use of smalltalk? Or are these somewhat 'add-on'
files for smalltalk? (The judgment as of what is 'minimal' use
is up to you.)
- /usr/share/gnu-smalltalk/unsupported/binary.c
rpmlint complains about this file as 'devel-file-in-non-devel-package'.
Would you explain why this file should be in main package?
Then:
1. From http://fedoraproject.org/wiki/Packaging/Guidelines :
* Timestamps
This package contains lots of text files (mainly *.st files), so
keeping timestamps is highly preferable because
- it shows when the file is written by upstream or vendor (as you)
- it may suggest whether vendor (you) have changed original content.
So please keep timestamps for text files included.
Then:
A. Try: 'make DESTDIR=$RPM_BUILD_ROOT INSTALL="install -c -p" install'
B. For "Fix broken Shebangs" section:
B-1 check if this section is still needed.
B-2 If so (i.e. this section is still needed), change the description
of this section so that the files which are actually not needed
to be fixed _WON'T_ change their timestamps.
* File and Directory Ownership
- %{_datadir}/aclocal/
This directory is owned only by automake and so -devel package should
require automake.
2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
(okay)
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list