[Bug 207781] Review Request: libmatheval - parse and evaluate symbolic expressions

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libmatheval - parse and evaluate symbolic expressions


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207781


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-10-01 20:23 EST -------
* source files match upstream:
   e88b3429da2758c799e6fbc44ac87416  libmatheval-1.1.3.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
  libmatheval-1.1.3-4.fc6.x86_64.rpm
   libmatheval.so.1()(64bit)
   libmatheval = 1.1.3-4.fc6
  =
   /sbin/ldconfig
   libmatheval.so.1()(64bit)
  libmatheval-devel-1.1.3-4.fc6.x86_64.rpm
   libmatheval-devel = 1.1.3-4.fc6
  =
   /bin/sh
   /sbin/install-info
   libmatheval = 1.1.3-4.fc6
   libmatheval.so.1()(64bit)

* %check is present and all tests pass (except for the one failure explained above):
   ERROR: All 7 tests were run,
   1 failed unexpectedly.
* shared libraries are added and ldconfig is run appropriately.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (ldconfig, install-info)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers are in the -devel subpackage.
* unversioned .so files are in the -devel subpackage.
* no pkgconfig files.
* no libtool .la droppings.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.