[Bug 208675] Review Request: miau - Full-featured IRC bouncer
bugzilla at redhat.com
bugzilla at redhat.com
Mon Oct 2 17:04:56 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: miau - Full-featured IRC bouncer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208675
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2006-10-02 13:04 EST -------
First review of miau:
1. From http://fedoraproject.org/wiki/Packaging/Guidelines :
* Scriptlets requirements
- This package should require /sbin/install-info as
Requires(post), Requires(preun).
- The scriplets of post, postun is incollect.
1. use || :
2. don't call "/sbin/install-info --delete" when
upgrading.
See the section "Texinfo" of:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
* The sources used to build the package must....
Well, I cannot directly access to
http://dl.sf.net/%{name}/%{name}-%{version}.tar.bz2 .
I prefer like:
http://umn.dl.sourceforge.net/sourceforge/%{name}/%{name}-%{version}.tar.gz
3. Other things I have noticed:
* I think "INSTALL" is not needed for document files.
This is required for installing this.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list