[Bug 209025] Review Request: xfce4-dev-tools - Xfce developer tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-dev-tools - Xfce developer tools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209025





------- Additional Comments From kevin at tummy.com  2006-10-02 21:55 EST -------
OK - Package name
OK - Spec file matches base package name.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
dc6403caf82edfb896eb3878385b439a  xfce4-dev-tools-4.3.99.1.tar.bz2
dc6403caf82edfb896eb3878385b439a  xfce4-dev-tools-4.3.99.1.tar.bz2.1
OK - Package compiles and builds on at least one arch.
OK - BuildRequires correct
See below - Package owns all the directories it creates.
OK - Package has no duplicate files in %files.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Spec has consistant macro usage.
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package doesn't own any directories other packages own.
See below - No rpmlint output.

SHOULD Items:

OK - Should include License or ask upstream to include it.
OK - Should build in mock.
Issues:

1. rpmlint says:

E: xfce4-dev-tools explicit-lib-dependency libtool

This can be ignored I think. rpmlint is just looking for anything starting
with lib...

However, there might be some more Requires.
I see it checking for the following at runtime:

## Check for a suitable make
## Check for autoconf, first trying autoconf-2.59, then autoconf-2.58, then
## Check for intltoolize
## Check for libtoolize
## Check for glib-gettextize
## Check for gtkdocize
## Check for aclocal, first trying aclocal-1.9, then aclocal-1.8, and finally
## Check for autoheader, first trying autoheader-2.59, then autoheader-2.58,
## Check for automake, first trying automake-1.9, then automake-1.8, and finally

2. Should require the Xfce package that owns datadir/xfce4...
Should perhaps be xfwm4? (which I need to fix to own that dir).


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.