[Bug 209399] Review Request: root-tail - an app o show log files on the root window

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: root-tail - an app o show log files on the root window


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209399


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |pertusus at free.fr
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From pertusus at free.fr  2006-10-05 05:20 EST -------
good:

* rpmlint is silent
* name follows guidelines
* follows packaging guidelines
* spec file is legible
* source match upstream
5a4b3c4c7ab3bed1f4575e9688aac5de  root-tail-1.2.tar.gz
* sane provides:
root-tail = 1.2-1
* not a lib, not a graphical app
* compile on x86
* use macros consistently
* no licence included, but no licence upstream
* directory owning right
* %files right
* doc not runtime

Needswork:
no debug package generated. The -g option is not used when building. 
It seems that the flags set by imake are similar with those
in RPM_OPT_FLAGS, but not exactly the same. From my tests, it seems
that something along (untested in a spec file) should do the trick:

make %{?_smp_mflags} CFLAGS="$RPM_OPT_FLAGS"

comment:
-Xext seems to be unneeded from ldd -u run on the executable,
and also -lX11, but it is strange for X11 since it uses header
files?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.