[Bug 208420] Review Request: conky - A system monitor for X originally based on the torsmo code

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: conky - A system monitor for X originally based on the torsmo code


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208420





------- Additional Comments From bugs.michael at gmx.net  2006-10-05 07:25 EST -------
* Hints for upstream:
 - remove the huge autom4te.cache directory from the source tarball


* Re: comment 6 : dlopening the *.so lib symlinks is an upstream bug.
They ought to dlopen the versioned libs instead.


* BuildRequires glib2-devel _and_ glib-devel? We do have glib2, and it
is found and built with, so old glib1 is not needed.


* BuildRequires xorg-x11-server-Xorg asks for an explanation in the spec
file, since this requirement is not obvious.


> ./configure: line 22513: AM_ICONV: command not found
> configure: WARNING: Could not find libiconv

??? -> /usr/include/iconv.h -> glibc-devel -> available by default


> checking for X... no

???


* %doc file INSTALL is irrelevant to RPM package users


* Backtrace at run-time:

(gdb) bt
#0  0x0083f402 in __kernel_vsyscall ()
#1  0x00a22d40 in raise () from /lib/libc.so.6
#2  0x00a24591 in abort () from /lib/libc.so.6
#3  0x00a5818b in __libc_message () from /lib/libc.so.6
#4  0x00adb161 in __chk_fail () from /lib/libc.so.6
#5  0x00ada663 in __strcpy_chk () from /lib/libc.so.6
#6  0x08064ecd in main (argc=1, argv=0xbf969144) at conky.c:6582
#7  0x00a0ff2c in __libc_start_main () from /lib/libc.so.6
#8  0x0804ab71 in _start ()

 => Blocker!

Insecure programming leads to this crash. "temp" array is too small
for the length of our locale env values. When started as
"LC_ALL=C conky" it works. Lines around 6582 of conky.c:

#ifdef X11
	char *s;
	char temp[10];        /* !!! */
	unsigned int x;

	if (((s = getenv("LC_ALL")) && *s) || ((s = getenv("LC_CTYPE")) && 
		     *s) || ((s = getenv("LANG")) && *s)) {
		strcpy(temp, s);     /* !!! */


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.