[Bug 209504] Review Request: perl-POE-Component-DBIAgent - POE Component for running asynchronous DBI calls
bugzilla at redhat.com
bugzilla at redhat.com
Thu Oct 5 20:43:23 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-POE-Component-DBIAgent - POE Component for running asynchronous DBI calls
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209504
tibbs at math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From tibbs at math.uh.edu 2006-10-05 16:43 EST -------
The only thing I can say about this is that the %description is actually less
useful than the Summary:. Perhaps you could consider adding the paragraph from
the README file which beging with "DBIAgent forks off"; it at least describes
what the module does. But I'll leave that up to you.
* source files match upstream:
be7797ba7eb147c8a2f19c89806e1d4b POE-Component-DBIAgent-0.26.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible. License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
perl(POE::Component::DBIAgent) = 0.26
perl(POE::Component::DBIAgent::Helper) = 0.03
perl(POE::Component::DBIAgent::Queue) = 0.02
perl-POE-Component-DBIAgent = 0.26-1.fc6
=
perl(:MODULE_COMPAT_5.8.8)
perl(Carp)
perl(DBI)
perl(Data::Dumper)
perl(POE)
perl(POE::Filter::Reference)
perl(Storable)
perl(constant)
perl(strict)
perl(vars)
* %check is present and all tests pass: (well, just one test)
t/1....ok
All tests successful.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list