[Bug 209144] Review Request: alsa-oss - Userspace OSS emulation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: alsa-oss - Userspace OSS emulation


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209144





------- Additional Comments From jima at beer.tclug.org  2006-10-06 09:20 EST -------
> - Don't delete libossredir.a: move it to the devel package. This is a wrapper
> library specifically meant for static linking (that's why the static linking 
> is hardcoded by upstream), to make oss redirection more efficient than the
> LD_PRELOAD "hack". I think this qualifies as a valid exception to the
> no-static-libs rule.

There's not a no-static-libs rule, it just says keep 'em in -devel (which I did
before).  Fair enough point, though; fixed.

> - Add oss-redir/README to the devel package as a %doc

Done.

> - Missing %defattr in the %files devel section

Ack!  Corrected, thanks for noticing.

> - x86_64 build suffers from rpath issues. The only fix i could find is to call
> 'autoreconf -f -i' before configure, and use '--disable-rpath' on the 
> configure line (and add automake and libtool as BRs). These changes can be 
> protected by an %ifarch x86_64.

As I don't have any x86_64 machines for development/testing purposes, I would
never have caught that.  I've made (I think) the appropriate fixes to my spec. 
Updated at:

http://beer.tclug.org/fedora-extras/alsa-oss/alsa-oss.spec
http://beer.tclug.org/fedora-extras/alsa-oss/alsa-oss-1.0.12-3.fc6.src.rpm

Let me know whether those changes look satisfactory.

Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.