[Bug 204700] Review Request: njb-sharp - C# bindings to libnjb

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: njb-sharp - C# bindings to libnjb


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204700


paul at all-the-johnsons.co.uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul at all-the-johnsons.co.uk




------- Additional Comments From paul at all-the-johnsons.co.uk  2006-10-07 12:33 EST -------
Okay, x things. 

First, are you intending to have this available for FC5 as well as FC6? If you
are then until mono in FC5 is updated, you'll need a hack otherwise it will be
broken for x86_64

Something like

%if "%{?fedora}" == "5"
%define monodir %{_prefix}/lib
%else
%define monodir %{_libdir}
%endif

You will then need patches for the makefile.am files which point statically to
/usr/lib and change them to @libdir at . These patches ONLY need to be applied if
you're not using them for FC5, so in %setup you have

%if "%{?fedora}" > "5"
%patch0 -p1
autoreconf
%endif

(obviously, this will mean you need to include the BRs for autoreconf - IIRC,
it's autoconf, automake and libtool)

2. Anything that is for a pkgconfig *must* be in it's own package - it doesn't
matter if it's a single line or not, it has to be in it's own -devel package.

3. You will need BR pkgconfig and monodoc (there may be some switch in the
configure script which can switch off monodoc). Me, I'd include it as the more
that goes in monodoc, the better.

4. Don't steel from SuSE - their spec files have been known to cause people's
brains to explode, implode and then make a sort of sqeeeeeeeee noise.

5. Not sure what you mean about these commented out lines

# These are for /usr/bin/monodoc, part of "mono-tools", not part of FC/FE 
# and not present in the current "mododoc" package.

If there is a problem with monodoc, please file a BZ report and I'll fix it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.