[Bug 188400] Review Request: ssmtp

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ssmtp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188400





------- Additional Comments From pertusus at free.fr  2006-10-09 05:06 EST -------
(In reply to comment #21)
> Thank you for the new review.
> 
> As suggested, I have removed the "provides" for the man pages and stubs which do
> nothing. 

The provides for %{_mandir}/man5/ssmtp.conf.5.gz is still there,
although this file is allready listed as a ssmtp file, and besides 
such a provides is of no use.

> I have also added the "-p" switch, but a quick look shows no
> differences in the behaviour... Maybe because %doc already preserves the
> timestamps and man pages are gzipped before being packaged. Nothing else is
> preserved from upstream.

I was too lazy to check exactly but it may be relevant for 
other packages...

> The fact that the included patches were retrieved from Debian and Mandrake
> respectively is mentioned in the very first entry of the Changelog. I have
> decided to rename the patches in order to maintain the more-or-less standard
> policy of patch names used in RH. 

Indeed, I didn't remarked it... The mandrake patch is very simple
so no issue. But in may opinion it would be better (though not a 
blocker) to have, in comment near the Patch:, the full url to the debian 
patch. 

> The included Debian patch is still at revision
> 6 because
> - major change in revision 7 is IPv6; the others are just Debian related.
> Unfortunately I have no IPv6 support around and cannot test
> - major change in rev 8 is the switch from openssl to gnutls. For the time being
> I cannot afford to test this either because all of the machines I run ssmtp on
> are production machines.
> Not to mention that the first listed change in rev7 is "ssmtp maintained via
> alioth: http://alioth.debian.org/projects/ssmtp/" but the link says "This
> Project Has Not Released Any Files" :) 
> I will again into the SSL differences some time later, probably next month.

>From a quick look at the latest debian patch, it seems ot me that 
the switch to gnutls hasn't been done very cleanly...

If there is no security related changes (as it seems to be the case)
it seems perfectly right to me not to use the latest patch. However
it also seems very clear to me that the debian patchset is the new 
upstream for the otherwise dead ssmtp package, so updating the package 
really means using the latest debian patches.

In my opinion, still, updating to the patchset 7 could be relevant, even 
if you cannot test ipv6, others could. I wouldn't personnaly make
that a blocker.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.