[Bug 209959] Review Request: tenr.de-styles-pkg - A collection of over 200 styles/themes for fluxbox

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tenr.de-styles-pkg - A collection of over 200 styles/themes for fluxbox


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209959





------- Additional Comments From miker5slow at grandecom.net  2006-10-09 09:00 EST -------

(In reply to comment #2)
> * There shouldn't be a '.' in the package name as seen here:
>   http://fedoraproject.org/wiki/Packaging/NamingGuidelines

no problem, easy fix

> 
> * The rpmlint issue is ignorable, although you may want to open
>   a bug about missing Creative Commons licences.
Good idea

> 
> * If I'm not wrong -r is impled by -a for cp.
nope thats correct, according to the man it implys -dpR
so Ill remove the r

> 
> * The Source0 should be an url. It seems to be
> http://www.tenr.de/files/fluxmod-styles-pkg.tar.bz2
This is not the same thing at all but I do plan to package these too so we will
get the package name fixed there too.

> What is a bit bad is that there is no versionning, you 
> should certainly ask upstream for a version string (in ascii
> ascending order...).
> 
done. He is doing it for me now.

> * %{_styledir}/ will be unowned.
How is the best way to resolve this?

 
> * The most annoying thing is that it doesn't work out of the box,
>   the new themes don't appear anywhere in the fluxbox menu...

the problem with making them work out of the box is that some how every user on
the system would need the menu in ~/.fluxbox/menu edited, even if they didnt
want the styles to begin with, only the admin wanted them on the system for them
to use. This package adds over 200 styles, and getting them all in your menu if
you dont want them can annoy you when you open the menu and get scrolled to
where they are, because the submenu it makes will cover the whole screen area. I
did include a README which has instructions for a user to add them to the menu.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.