[Bug 210189] Review Request: granule - Gtk+-based flashcards program

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: granule - Gtk+-based flashcards program


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210189





------- Additional Comments From giallu at gmail.com  2006-10-10 17:55 EST -------
I had a quick look at the spec and I regret to say there are a lot of issues
with it.

In order to speed up this thing, I'll give you some suggestions:

start building a spec from the template you get from the command
"rpmdev-newspec" (in package rpmdevtools): this will save you from a lot of problems

always run rpmlint on the resulting src.rpm: this gives you more hints on things
to fix before submitting again.

Always prefer standard macros instead of redefining them:
http://fedoraproject.org/wiki/Extras/RPMMacros

Now a quick list of thing to check:
* Do not use tags like Packager and Prefix
* Buildroot is not the recommended one
* Do not use both spaces and tabs for indentation
* Summary is a little too concise...
* a GUI app with no BuildRequire tags look suspicious :)
* the commands you use in %build probably calls for more BRs (hint: mock)
* no need to test for SMP in the build phase: just use "make %{?_smp_mflags}"
* %find_lang do not seems to be used in the proper way
* always $RPM_BUILD_ROOT in %install
* usual defattr on files is %defattr(-,root,root,-)
* you do not seems to own the directory %{datadir}/granule
* the .destkop fil is not installed in the proper way

All of this is covered the the packaging guidelines:
http://fedoraproject.org/wiki/Packaging/Guidelines





-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.