[Bug 210285] Review Request: kfolding - KDE kicker applet for Folding at home

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kfolding - KDE kicker applet for Folding at home


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210285





------- Additional Comments From prockai at redhat.com  2006-10-11 11:47 EST -------
The new srpm looks good to me, only few little issues:
     75 %{_datadir}/apps/kfolding/pics/
is redundant and
     84 * Wed Oct 11 2006 Matej Cepl <mcepl at redhat.com> - 1.0.0-rc2
has wrong version number (should be version-release, that is 1.0.0-0.rc2).

rpmlint says
E: kfolding 
file-in-usr-marked-as-conffile /usr/share/apps/kfolding/default.cfg
W: kfolding 
symlink-should-be-relative /usr/share/doc/HTML/en/kfolding/common /usr/share/doc/HTML/en/common

The default.cfg file probably shouldn't be marked conffile, the program, if i 
understand correctly, should create ~/.kde/share/apps/kfolding/default.cfg for 
user to modify, the file in /usr is just a set of system-wide defaults.

The symlink should be relativized to ../common.

I have tried to not miss anything this time, hope it's really all :).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.