[Bug 209614] Review Request: wmmemload - windowmaker dock app

bugzilla at redhat.com bugzilla at redhat.com
Thu Oct 12 19:49:37 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wmmemload - windowmaker dock app


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209614





------- Additional Comments From pertusus at free.fr  2006-10-12 15:49 EST -------
Everytime you repost the package you are submitting after 
having made a change, you should bump the release and add
a changelog entry (just like how you would have done when
modifying a package), remake a src.rpm and repost it. There may
be exceptions for minor changes, but the rule is to repost a 
new srpm.

parallel make is preferred:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-525c7d76890cb22df33b759c65c35c82bf434d2e

regarding the glob for the man pages
%{_mandir}/man1/wmmemload.1.*
won't catch the case when there is no compression, while
%{_mandir}/man1/wmmemload.1*
do. This is not a blocker.

During the build make triggers the whole autotools stuff. This is bad:

.......
+ make
cd . && aclocal
acinclude.m4:8: warning: underquoted definition of DA_CHECK_LIB
  run info '(automake)Extending aclocal'
  or see http://sources.redhat.com/automake/automake.html#Extending-aclocal
acinclude.m4:20: warning: underquoted definition of DA_CHECK_HEADER
cd . && automake --gnu --include-deps Makefile
cd . && autoconf
/bin/sh ./config.status --recheck
....

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list