[Bug 210781] Review Request: libctl - Guile-based support for flexible control files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libctl - Guile-based support for flexible control files


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210781





------- Additional Comments From tibbs at math.uh.edu  2006-10-14 22:49 EST -------
The only thing that gives me any pause about this package is /usr/include/ctl.h,
which does seem a bit generic and prone to conflicts in the future.  I don't
really know what to do about it, though.  If it were moved into a subdirectory
of /usr/include or renamed, then Fedora would differ from every other
installation.  And there's no convenient .pc file to use to relocate things.
Any thoughts on the matter?

* source files match upstream:
   dff367aa94e68a507678f0f3d48b1165  libctl-3.0.2.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
  libctl-3.0.2-3.fc6.x86_64.rpm
   libctl.so.3()(64bit)
   libctlgeom.so.3()(64bit)
   libctl = 3.0.2-3.fc6
  =
   /sbin/ldconfig
   guile
   libctl.so.3()(64bit)
   libctlgeom.so.3()(64bit)
   libguile.so.17()(64bit)

  libctl-devel-3.0.2-3.fc6.x86_64.rpm
   libctl-devel = 3.0.2-3.fc6
  =
   /bin/sh
   libctl = 3.0.2-3.fc6
   libctl.so.3()(64bit)
   libctlgeom.so.3()(64bit)
  
* %check is not present; no test suite upstream.
* shared libraries are present; ldconfig is called properly.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (ldconfig)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers are in the -devel package.
* no pkgconfig files.
* no libtool .la droppings.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.