[Bug 210826] Review Request: genius - An arbitrary precision integer and multiple precision floatingpoint calculator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: genius - An arbitrary precision integer and multiple precision floatingpoint calculator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210826


ed at eh3.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |ed at eh3.com
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From ed at eh3.com  2006-10-18 00:14 EST -------
OK, the -2 release now builds with mock!

needswork:
 - rpmlint reports:
     E: genius-debuginfo script-without-shebang 
       /usr/src/debug/genius-0.7.6.1/mpfr/mul.c
     W: genius-devel no-documentation
     W: gnome-genius no-documentation
   the warnings are harmless and can be ignored but the error can be 
   fixed by changing the file's permissions within the build dir.

good:
 + spec is legible
 + source matches upstream
 + license looks good and is correctly included
 + spec file looks sane and is legible
 + builds in mock on FC-5 i386
 + uses %find_lang macro correctly
 + dir ownership look OK
 + appears to have no shared libs
 + permissions look good (except for the one exception above)
 + has proper clean section and command
 + proper use of devel
 + code not content
 + no *.la files
 + scripts appear to be sane
 + proper use of desktop-file-install
 + consistent use of macros
 + installs and runs without seg-faulting on i386 FC-5

I don't see any blockers here so its APPROVED.

Please fix the permissions on that one file before submitting 
the first build.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.