[Bug 211625] Review Request: tcd-utils - TCD (Tide Constituent Database) Utils

bugzilla at redhat.com bugzilla at redhat.com
Sat Oct 21 10:07:22 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tcd-utils - TCD (Tide Constituent Database) Utils


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211625





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-10-21 06:07 EST -------
(In reply to comment #12)
> > You have not noticed 
> 
> Uh, come on, that's sort of a presumptuous comment. 
Sorry for this comment.

> As soon as sourcing special files would be
> needed _at build-time_ for a reproducible build, it would add a requirement
> at the spec file level.
> 
> > relogin
> 
> You are not serious about such a requirement, are you?

I am _SERIOUS_ . There can be a case that user sets various environment
during many other works.

Relogin is truly NEEDED because it flushes all other settings (such as
environment) a user (who are trying to rebuild) has done and
sets the inital environment needed.

This is especially true for mockbuild. At first, mockbuild "user" has
set no environment. Then to ensure build environment, mockbuild "user"
really has to relogin.

> That would be a step backwards. It would mean that any user, who uses
> a package tool to add or update packages, needs to do a non-obvious
> preventive re-login. It would also lead to non-reproducible builds,
> because the system's QTDIR is not used when a different one is set.

? Relogin is needed to ensure reproducible builds to ensure system
environment is correctly set. If user has set a different environment
(such as QTDIR) and rebuild srpm without login, this surely leads to
unpleasant result.

Surely rebuild should be done under the same environment, not under
different environment set by user. The only thing to do this is relogin.

> 
> I've been doing package reviews for a very long time. But the ticket for
> this tiny package has reached a point already where it becomes too tiresome.
> Even if it may be a tiny detail, I won't approve a package like that.

Sorry to hear that, however I think this is not a tiny thing.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list