[Bug 210757] Review Request: magicor - Push ice blocks around to extenguish all fires

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: magicor - Push ice blocks around to extenguish all fires


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210757





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-10-21 15:57 EST -------
(In reply to comment #2)

> needs work
> Under %files
> non-conffile-in-etc /etc/magicor.conf - needs %config (noreplace) before the
> %{_sysconfdir)

Fixed

> needs a %build section (even if it's empty - I'll need to check on this though)
> 

For packages which don't need any building I always get comments on how I handle
it if I add a comment that there is nothing to build, but leave %build
uncommented, people say that I should comment it (thats how/when I started
commenting %build itself). And if I do comment it I get remarks too.

Sofar I have several packages with %build commented and they all work fine, so I
would rather leave this as is.

---

Here is a new version with the %config(noreplace) added:
Spec URL: http://people.atrpms.net/~hdegoede/magicor.spec
SRPM URL: http://people.atrpms.net/~hdegoede/magicor-0.1-2.fc6.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.