[Bug 211336] Review Request: adesklets - A simple architecture for desktop applets

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: adesklets - A simple architecture for desktop applets
Alias: adeskets

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211336





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-10-28 08:25 EST -------
Well, currently I cannot check this package (adesklets) with
installing this because there is a issue on this package which
prevents me from doing so.

A. From http://fedoraproject.org/wiki/Packaging/Guidelines :
* Use rpmlint.
  - Well, please check your packages by rpmlint (in Fedora Extras)
    before you submit your packages.
    rpmlint is not silent.
----------------------------------------------------------------
E: adesklets info-dir-file /usr/share/info/dir
   Existence of /usr/share/info/dir breaks all info information
   in other packages. Please remove this.

W: adesklets hidden-file-or-dir \
     
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/adesklets/.packlist
W: adesklets perl-temp-file \
     
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/adesklets/.packlist
   These files are not necessary.

E: adesklets non-standard-executable-perm \
      /usr/lib/perl5/vendor_perl/5.8.8/updateproto.pl 0555
   Please explain why the permission of this file is not 0755.

W: adesklets file-not-utf8 /usr/share/info/adesklets_fr.info.gz
   This file is encoded in ISO-8859-1 (perhaps). Change the encoding to UTF-8.

W: adesklets perl-temp-file
/usr/lib/perl5/5.8.8/i386-linux-thread-multi/perllocal.pod
   This file is unneeded.

W: adesklets spurious-bracket-in-%preun
   Please use :
        if [ $1 = 0 ]; then

W: adesklets mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 13)
   For indentation, please use spaces or tabs, not both.
-----------------------------------------------------------------------

* Requires:
  - python-abi
    This is not required as described in
http://fedoraproject.org/wiki/Packaging/Python .

* BuildRequires:
  - The results of rpmbuild and mockbuild differs.
------------------------------------------------------------------------
[tasaka1 at localhost i386]$ rpm -qp --requires adesklets-0.6.1-3.i386.rpm | sort >
1.txt
[tasaka1 at localhost i386]$ rpm -qp --requires adesklets-0.6.1-3.fc7.i386.rpm |
sort > 2.txt
[tasaka1 at localhost i386]$ diff -u 1.txt 2.txt 
--- 1.txt       2006-10-28 21:06:43.000000000 +0900
+++ 2.txt       2006-10-28 21:06:46.000000000 +0900
@@ -6,7 +6,6 @@
 /usr/bin/env  
 /usr/bin/perl  
 libImlib2.so.1  
-libX11.so.6  
 libc.so.6  
 libc.so.6(GLIBC_2.0)
-----------------------------------------------------------------------
Mockbuild buildlog says:
-----------------------------------------------------------------------
.........
checking for X... no
.........
configure: WARNING:
-----------------------------------------------------
you choosed to perform an `X Window less' build -
which means you will eventually end up with
a strictly command line program free of all
dependencies on xlib. If it is not what you intended
please reconfigure. For this to work you do need first
to configure your Imlib2 incantation for not using
X Window itself.
-----------------------------------------------------
................
-----------------------------------------------------------------------
   - Check the dependency for X related packages.

* Duplication of system libraries
   - /usr/share/adesklets/Vera.ttf
     Vera.ttf is included in bitstream-vera-fonts rpm and should not be 
     included in this package.

* Desktop files
  - This is GUI application and a appropriate application file should
    be installed.

* File and Directory Ownership
   - This package owns the following directories. This should not.
   /usr/lib/perl5/5.8.8
   /usr/lib/perl5/5.8.8/i386-linux-thread-multi
   /usr/lib/perl5/vendor_perl
   /usr/lib/perl5/vendor_perl/5.8.8
   /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi
   /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto

B. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
* MUST: The sources used to build the package must ...
  I recommend that you use %{name}-%{version}.tar.bz2

* MUST: A package must not contain any duplicate files in the %files listing.
  Duplicate lists found.
---------------------------------------------------------------------
warning: File listed twice: /usr/lib/perl5/vendor_perl/5.8.8/adesklets.pm
warning: File listed twice: /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi
warning: File listed twice:
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto
warning: File listed twice:
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/adesklets
warning: File listed twice:
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/adesklets/.packlist
warning: File listed twice: /usr/lib/perl5/vendor_perl/5.8.8/updateproto.pl
---------------------------------------------------------------------
  Please fix all.

C. Other issues I have found.
* Well, this is not a full review as I cannot install this unless the issues
  above is resolved.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.