[Bug 204421] Review Request: kdetv - KDE application for watching TV

bugzilla at redhat.com bugzilla at redhat.com
Fri Sep 1 14:29:32 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdetv - KDE application for watching TV


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204421





------- Additional Comments From rdieter at math.unl.edu  2006-09-01 10:29 EST -------
Looks good, off-hand a few quickies:

0.  Curious, why is this GPL/LPGL?

1.  SHOULD: instead of manually deleting applnk, instead use 
desktop-file-install --delete-original 

2.  SHOULD: Since this isn't a .desktop provided by fedora, imo, you needn't use:
desktop-file-install --vendor="fedora"
but instead use --vendor="" 


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list