[Bug 204417] Review Request: telepathy-gabble - A Jabber/XMPP connection manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: telepathy-gabble - A Jabber/XMPP connection manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204417





------- Additional Comments From sander at hoentjen.eu  2006-09-01 13:51 EST -------
GOOD
- package meets naming and packaging guidelines.
- specfile is properly named, is cleanly written and uses macros consistently.
- dist tag is present.
- build root is correct.
- license field matches the actual license.
- license is open source-compatible.  License text included in package.
- source files match upstream: feb6766c1d2f984f1f37ffc8889e6faa
- BuildRequires are proper.
- package builds in mock (x86_64).
- rpmlint is silent.
- final provides and requires are sane:
 telepathy-gabble-0.3.1-1.fc6.x86_64.rpm
  telepathy-gabble = 0.3.1-1.fc6
 =
  libdbus-1.so.3()(64bit)  
  libdbus-glib-1.so.2()(64bit)  
  libglib-2.0.so.0()(64bit)  
  libgobject-2.0.so.0()(64bit)  
  libloudmouth-1.so.0()(64bit)  

 telepathy-gabble-debuginfo-0.3.1-1.fc6.x86_64.rpm
  telepathy-gabble-debuginfo = 0.3.1-1.fc6
 =
- no shared libraries are present.
- package is not relocatable.
- owns the directories it creates.
- doesn't own any directories it shouldn't.
- no duplicates in %files.
- file permissions are appropriate.
- %clean is present.
- no scriptlets present.
- code, not content.
- documentation is small, so no -docs subpackage is necessary.
- %docs are not necessary for the proper functioning of the package.
- no headers.
- no pkgconfig files.
- no libtool .la droppings.
- not a GUI app.
- not a web app.

MINOR:
Not the latest version is being packaged, but that is ok in this case. If you do
want to package the latest version (0.3.2) you can use
--disable-loudmouth-versioning
In both cases (if i understand correctly) there might be some crashing due to
connection errors, but this will be fixed when the unstable branch of loudmouth
is released as stable.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.