[Bug 205030] Review Request: atomix - Little mind game where you have to build molecules out of atoms lying around

bugzilla at redhat.com bugzilla at redhat.com
Sun Sep 3 11:54:13 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: atomix - Little mind game where you have to build molecules out of atoms lying around


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205030





------- Additional Comments From fedora at leemhuis.info  2006-09-03 07:54 EST -------
(In reply to comment #1)
> The game is setgid games, but doesn't appear to completely drop setgid
> privileges after starting up, according to /proc/<pid>/status. [...]

Yes, sorry, I wanted to comment on this. Citing
http://www.fedoraproject.org/wiki/Extras/SIGs/Games
"If necessary, a game can be made setgid 'games' in order to allow a shared
scoreboard file. But only if necessary, and care should be taken to drop setgid
privileges when not needed. The following example shows how to properly drop
setuid/setgid privileges. [...]"

I'm not a real C-Programmer (never found time for it :-/ and these days my work
around Fedora consumes all of my free time) so I can't integrate above or
comment closer on what Wart noticed in Comment #1. I'd be glad if someone from
the Games SIG (or someone else) could look closer into this whole stuff.

(In reply to comment #2)
> You're missing find-langs from the spec file - there are a lot of translation
> files in there.

/me looks closer -- yes, seems so, but they didn't get installed. (even with
gettext around on the system). Ahh, seems it's a upstream problem. See GNOME
bz#334319 . I worked around this bug with running
sed  -i 's!^SOURCES = !&\n'"$(grep "^CATALOGS" po/Makefile.in)"'!' po/Makefile
after configure. There are probably better ways do do that. Suggestion welcomed.

Latest package now atomix-2.14.0-2

Spec URL: 
  http://www.leemhuis.info/files/fedorarpms/SPECS.fdr/atomix.spec
Diff URL: 
  http://www.leemhuis.info/files/fedorarpms/SPECS.fdr/atomix.spec.diff
SRPM URL: 
  http://www.leemhuis.info/files/fedorarpms/SRPMS.fdr/atomix-2.14.0-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list