[Bug 205127] Review Request: ekg - A client compatible with Gadu-Gadu

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ekg - A client compatible with Gadu-Gadu


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205127


mr.ecik at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mr.ecik at gmail.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From mr.ecik at gmail.com  2006-09-04 13:15 EST -------
Official review:

MUST items:

 * rpmlint output:
W: libgadu no-documentation
 * package is named good.
 * spec file is named good.
 * package almost meets Packaging Guidelines (it'll be defined later)
 * License field matches actual license
 * license is NOT included in %doc in libgadu
 * spec file is legible
 * md5sums are matching (b4ea482130e163af1456699e2e6983d9)
 * package successfully builds on x86_64
 * build dependencies are properly listed in BuildRequires
 * no locales
 * package contains shared library files and package calls ldconfig
in %post and %postun
 * package owns its directories
 * no duplicates in %files
 * correct %defattr lines
 * proper %clean section
 * no gui

THINGS you have to do:

 * add %{?dist} tag to Release
 * add license file to libgadu package (COPYING is in lib directory)
 * remove python BR, because python-devel will add it

If you fix what I mentioned above, I'll approve it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.