[Bug 200941] Review Request: SooperLooper, a realtime software looping sampler (&Jack client)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: SooperLooper, a realtime software looping sampler (&Jack client)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200941





------- Additional Comments From green at redhat.com  2006-09-08 22:03 EST -------
I think there are only a couple of minor issues.  See the lines that start with
'X'.  This assumes the tweaks in my uploaded spec file are accepted.

* package meets packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.  
* build root is correct.
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* license field matches the actual license.
* license is open source-compatible.
* License text included in package.
* source files match upstream. md5sum...
9b34c7cb8fc6daa4c7a9c17004680dac  sooperlooper-1.0.8c.tar.gz
* latest version is being packaged.
X BuildRequires are almost proper.
  - Look at the changes I made in the spec file I attached in Comment #14 to 
    handle FC releases > 5.
* package builds in mock.
* rpmlint says:
  W: sooperlooper mixed-use-of-spaces-and-tabs
  I just use the emacs untabify command to clean these things up.
* final provides and requires are sane:
sooperlooper-1.0.8-0.2.c.fc6.i386.rpm
  sooperlooper = 1.0.8-0.2.c.fc6
  =
  libasound.so.2
  libasound.so.2(ALSA_0.9)
  libjack.so.0
  liblo.so.0
  libncurses.so.5
  libsamplerate.so.0
  libsamplerate.so.0(libsamplerate.so.0.0)
  libsigc-1.2.so.5
  libsndfile.so.1
  libsndfile.so.1(libsndfile.so.1.0)
  libstdc++.so.6
  libstdc++.so.6(CXXABI_1.3)
  libstdc++.so.6(GLIBCXX_3.4)
  libwx_baseu-2.6.so.0
  libwx_baseu-2.6.so.0(WXU_2.6)
  libwx_baseu_net-2.6.so.0
  libwx_baseu_xml-2.6.so.0
  libwx_gtk2u_adv-2.6.so.0
  libwx_gtk2u_adv-2.6.so.0(WXU_2.6)
  libwx_gtk2u_core-2.6.so.0
  libwx_gtk2u_core-2.6.so.0(WXU_2.6)
  libwx_gtk2u_core-2.6.so.0(WXU_2.6.2)
  libwx_gtk2u_html-2.6.so.0
  libwx_gtk2u_html-2.6.so.0(WXU_2.6)
  libwx_gtk2u_qa-2.6.so.0
  libwx_gtk2u_xrc-2.6.so.0
  libxml2.so.2
  libz.so.1
* shared libraries not present.
* package is not relocatable.
* owns the directories it creates.
X Should Require hicolor-icon-theme since it places an icon in a directory owned
by that package.  This is something I just learned about myself, and plan on
cleaning up my old packages.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is not present
* scriptlets OK.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
X .desktop file is installed properly, but should refer to "SooperLooper", not
"Sooperlooper".
* not a web app.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.