[Bug 197420] Review Request: php-pear-Payment-Process - PEAR: Unified payment processor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Payment-Process - PEAR: Unified payment processor
Alias: pear-Payment-Process

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197420


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-09-09 11:03 EST -------
I guess you have a redundant Requires: php there.

* source files match upstream:
   d63b822c194775f5dd3cbd23fb500322  Payment_Process-0.6.5.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent (except for that bogus warning)
* final provides and requires are sane:
   php-pear(Payment_Process) = 0.6.5
   php-pear-Payment-Process = 0.6.5-1.fc6
  =
   /bin/sh
   /usr/bin/pear
?  php
   php-pear(Net_Curl) >= 1.2.0
   php-pear(PEAR)
   php-pear(Validate) >= 0.5.0
   php-pear(Validate_Finance_CreditCard) >= 0.5.0
   php-pear(XML_Parser) >= 1.2.6
* %check is not present; no test suite upstream.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets OK (PEAR module installation)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.