[Bug 205887] Review Request: perl-HTTP-Body - HTTP Body Parser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-HTTP-Body - HTTP Body Parser


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205887





------- Additional Comments From tibbs at math.uh.edu  2006-09-09 15:18 EST -------
The %description is a bit lacking, but the package doesn't 

Some checks are skipped due to missingg BuildRequires; suggest adding
perl(Test::Pod) and perl(Test::Pod::Coverage).

Some of your explicit Requires: duplicate the ones that rpm finds: perl(Carp),
perl(File::Temp) >= 0.14, perl(IO::File).

* source files match upstream:
   e7f5963abece523dd9be27db3d37aaea  HTTP-Body-0.6.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
X BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
X final provides and requires are sane:
   perl(HTTP::Body) = 0.6
   perl(HTTP::Body::MultiPart)
   perl(HTTP::Body::OctetStream)
   perl(HTTP::Body::UrlEncoded)
   perl-HTTP-Body = 0.6-1.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
X  perl(Carp)
   perl(File::Temp) >= 0.14
X  perl(File::Temp) >= 0.14
   perl(HTTP::Body::MultiPart)
   perl(HTTP::Body::OctetStream)
   perl(HTTP::Body::UrlEncoded)
   perl(IO::File)
X  perl(IO::File)
   perl(YAML) >= 0.39
   perl(base)
   perl(bytes)
   perl(strict)
X %check is present but some tests are skipped due to missing BuildRequires:
   All tests successful, 2 tests skipped.
   Files=6, Tests=69,  1 wallclock secs ( 0.47 cusr +  0.12 csys =  0.59 CPU)
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.