[Bug 200941] Review Request: SooperLooper, a realtime software looping sampler (&Jack client)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: SooperLooper, a realtime software looping sampler (&Jack client)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200941





------- Additional Comments From nando at ccrma.stanford.edu  2006-09-09 15:55 EST -------
(In reply to comment #16)
> I think there are only a couple of minor issues.  See the lines that start with
> 'X'.  This assumes the tweaks in my uploaded spec file are accepted.
> 
> X BuildRequires are almost proper.
>   - Look at the changes I made in the spec file I attached in Comment #14 to 
>     handle FC releases > 5.

Should this be "%{fedora}" >= 4 or just ommit it? I think current Fedora Extras
for 4 and 5 has wxGTK as the name of the package with the proper
obsoletes/provides for wxGTK2, right? Is this the version being used by your
build system?

> * rpmlint says:
>   W: sooperlooper mixed-use-of-spaces-and-tabs
>   I just use the emacs untabify command to clean these things up.

Fixed now in my copy, thanks.

> X Should Require hicolor-icon-theme since it places an icon in a directory owned
> by that package.  This is something I just learned about myself, and plan on
> cleaning up my old packages.

First time I hear about this. Makes sense as this is not something that could be
done automatically by rpm, right? Lots of packages will need this...

> X .desktop file is installed properly, but should refer to "SooperLooper", not
> "Sooperlooper".

Fixed, thanks again. 

I'll wait to hear from you on the wxGTK/wxGTK2 name before releasing another
spec/srpm. 


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.