[Bug 203520] Review Request: evolution-brutus

bugzilla at redhat.com bugzilla at redhat.com
Tue Sep 12 09:49:54 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: evolution-brutus
Alias: evolution-brutus

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203520





------- Additional Comments From colding at omesc.com  2006-09-12 05:49 EST -------
(In reply to comment #28)
> --------------------------------------------------
> I cannot sponsor you because I am not a member of
> sponsors. I can do only pre-review of this package.
> --------------------------------------------------

Yes, but I want to express my gratitude to you for doing this 
pre-review anyway. Thanks!


> 1. From http://fedoraproject.org/wiki/Packaging/Guidelines :
> 
> * Timestamps
>   - These packages include many text files and preserving timestamps
>     is then preferable. Try to keep timestamps (can this package
>     accept 'make INSTALL="install -c -p" install'?)

Fixed.


> * File and Directory Ownership
>   - The following directories are not owned by any packages.
>     /usr/include/evolution-data-server-1.8/brutus/
>     /usr/share/idl/brutus/

Fixed I hope. I added the directories before the files within 
them and prefixed with the %dir directive. That should fix 
it, right?


> 2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
>    = Nothing.
> 
> 3. Other things I have noticed :
>    - Well, %{find_lang} %{name}-2.8 perhaps means:
>      Conflicts: evolution < 2.7
>      Conflicts: evolution >= 2.9

I am not sure if anything is wrong here. The "2.8" version tag is 
autogenerated during autogen.sh execution from the spec.in file. I can 
see that it would complicate matters if the SRPM that is generated for 
FC6 is used under, say, FC5. Should I completely drop the version tag here?


New release here:

Spec URL:
http://www.omesc.com/content/downloads/dist/Fedora%20Core%206/SPECS/evolution-brutus.spec
SRPM URL:
http://www.omesc.com/content/downloads/dist/Fedora%20Core%206/SRPMS/evolution-brutus-1.1.6-9.src.rpm


Thanks,
  jules



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list