[Bug 197732] Review Request: optipng - a PNG optimizer and converter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: optipng - a PNG optimizer and converter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197732


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |kevin at tummy.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From kevin at tummy.com  2006-09-13 00:04 EST -------
OK - Package name
OK - Spec file matches base package name.
OK - Meets Packaging Guidelines.
OK - License (zlib/libpng)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
a6f3234a47464ecc1f455b52f0769492  optipng-0.5.3.tar.gz
a6f3234a47464ecc1f455b52f0769492  optipng-0.5.3.tar.gz.1
OK - Package compiles and builds on at least one arch.
OK - BuildRequires correct
OK - Package owns all the directories it creates.
OK - Package has no duplicate files in %files.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Spec has consistant macro usage.
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package doesn't own any directories other packages own.
See below - No rpmlint output.

SHOULD Items:

OK - Should include License or ask upstream to include it.
 - Should build in mock.

Issues:

1. version 0.5.4 is out now.

2. You have 2 commented out lines:
#BuildRequires:
#Requires:   

Might just remove those?

3. rpmlint says:

W: optipng invalid-license zlib/libpng
W: optipng invalid-license zlib/libpng
W: optipng-debuginfo invalid-license zlib/libpng

This can be ignored (see bug 198616).

E: optipng-debuginfo empty-debuginfo-package

Not sure whats causing that. You are building with -g
It would be good to fix however.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.