[Bug 202901] Review Request: pgFouine - PostgreSQL log analyzer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pgFouine -  PostgreSQL log analyzer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202901





------- Additional Comments From toshio at tiki-lounge.com  2006-09-16 11:16 EST -------
MD5Sums
09cccc6978d9e953fb9a12487d75455d  pgfouine-0.7-4.src.rpm
ad2b56340581758fbda051abdc340d71  pgfouine.spec
c6b09d495fd11e0b8e9b4b86e4252449  pgfouine-0.7-include_path.patch
4ad02f17d9da3789e548bac77fd2f2a5  pgfouine-0.7.tar.gz

Blockers:
* Macros are used everywhere except in the patch file.

  As long as the patch defines "/usr/share/..." explicitly, the sed line in
  the spec file won't accomplish anything.  If the patch instead defines it as
  @INCLUDEPATH@ then the sed substitution will change @INCLUDEPATH@ into
  whatever the datadir is.  Eventually, the upstream build script can do the
  substitution itself based on what the value of an ENVIRNMENT VARIABLE or
  define passed to make.

Fixed:
* Source matches upstream tarball now.  One thing to remember is that you
  should be slightly paranoid as a packager.  The software that you package is
  going to be installed on a lot of end-user machines.  If someone says they
  are upstream and sends you a tarball you should still check it against the
  tarball on the upstream site, compare to upstream gpg signatures or MD5Sums,
  check against tarballs in packages from other distributions, or etc.  You
  only have a reviewer checking MD5Sums while the package is being submitted.
  Once it is in the repository it is up to you to ensure that the package
  continues to contain the source from upstream.
* INSTALL has been removed and ChangeLog added.
* Tests have been removed from the binary package.
* buildroot check was removed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.