[Bug 206266] Review Request: transmission - lightweight GTK+ BitTorrent client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: transmission - lightweight GTK+ BitTorrent client


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206266


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |kevin at tummy.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From kevin at tummy.com  2006-09-23 02:14 EST -------
OK - Spec file matches base package name.
OK - Meets Packaging Guidelines.
OK - License (MIT)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
1156a88c77ab71782b9261881ea13811  Transmission-0.6.1.tar.gz
1156a88c77ab71782b9261881ea13811  Transmission-0.6.1.tar.gz.1
OK - Package compiles and builds on at least one arch.
OK - BuildRequires correct
OK - Spec handles locales/find_lang
See below - Spec has needed ldconfig in post and postun
OK - Package owns all the directories it creates.
OK - Package has no duplicate files in %files.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Spec has consistant macro usage.
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package is a GUI app and has a .desktop file
OK - Package doesn't own any directories other packages own.
OK - No rpmlint output.

SHOULD Items:

OK - Should include License or ask upstream to include it.
OK - Should build in mock.

Issues:

1. You have:
Requires(post):   /sbin/ldconfig
Requires(postun): /sbin/ldconfig

But there are no libraries in this package, and you don't call
ldconfig in post/postun. Should remove those?

2. Your desktop-file-install and update-desktop-database
calls don't seem to quite match the guidelines on:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
and
http://fedoraproject.org/wiki/Packaging/Guidelines#desktop

3. You shouldn't use
%makeinstall
if you can avoid it.
See:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-
fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002

Can you use make DESTDIR=%{buildroot} install or make DESTDIR=$RPM_BUILD_ROOT 
install?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.