[Bug 175433] Review Request: tor - Anonymizing overlay network for TCP (The onion router)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tor - Anonymizing overlay network for TCP (The onion router)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175433





------- Additional Comments From enrico.scholz at informatik.tu-chemnitz.de  2006-09-25 02:42 EST -------
thx

* Mon Sep 25 2006 Enrico Scholz <enrico.scholz at informatik.tu-chemnitz.de> - 0.1.1.23-3
- removed '.have-lsb' and related logic in logrotate script; check for
  existence of the corresponding initscript instead of
- fixed bare '%' in changelog section

http://ensc.de/fedora/tor/


========

> * The gpg file is nice in that it alerts me to its presence on the
>   upstream download site but unless I have the signing gpg key in my
>   web of trust...

it's an habit from old fedora.us days. But I think a good one;
being in somebody's web-trust is not so difficultly as your comment
suggests. E.g. signer of tor is verified in my trustdb



> W: tor mixed-use-of-spaces-and-tabs

rpmlint bug; seems to be triggered by

| sed -i -e '...
| <TAB><WS>+'...

which happens due to indentation reasons


> W: tor-lsb hidden-file-or-dir /etc/tor/.have-lsb
> E: tor-lsb zero-length /etc/tor/.have-lsb
> W: tor-lsb non-conffile-in-etc /etc/tor/.have-lsb
>   - The .have-lsb file seems to be a marker identifying which set of init
>     scripts is installed for things like the logrotate script.  So it's state
>     of the system rather than configuration.  So not marking it %config makes
>     sense.  But putting it in /var might be better than /etc.  Also, is there
>     a reason to make it hidden?  If not, perhaps: /var/lib/tor/have-lsb would
>     be better.

I removed the '.have-XXX' stuff completely. But '/var/lib/tor' would
have been a bad place because the have-XXX files are files used directly
by 'root' while '/var/lib/tor' is owned by 'toranon'. Nevertheless,
should not be an issue anymore.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.