[Bug 207761] Review Request: xpdf - A PDF file viewer for the X Window System

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xpdf - A PDF file viewer for the X Window System


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207761





------- Additional Comments From pertusus at free.fr  2006-09-25 02:49 EST -------
(In reply to comment #9)
> I disagree on two items:
> 
> - the lang on the config files, the config files are actually in english.

Indeed, but the %lang, if I'm not wrong tells which files are interesting
for which language, not the language of the file. Anyway putting %lang 
here would certainly unnecessarily clutter the spec, so do what you
prefer. In fact proposed that because they were previously in such a
place that they had a %lang, not because I care a lot about this kind
of stuff.

> - While the BuildRequires: desktop-file-utils is correct, the Requires(post) and
> (postun) are also correct due to the scriptlet in %post and %postun
> (update-desktop-database is called).

This has changed in the guidelines, to avoid Requires bloat, quoting
(you? ;-):

"Note: For FC5+, this scriptlet follows the same convention as mimeinfo files
and gtk-icon-cache. Namely, the spec file should not Require desktop-file-utils
for this."



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.