[Bug 208169] Review Request: python-twisted-core - An asynchronous networking framework written in Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-twisted-core - An asynchronous networking framework written in Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208169


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |paul at city-fan.org




------- Additional Comments From paul at city-fan.org  2006-09-27 12:39 EST -------
First pass comments:

1. The files list is very long and results in lots of "File listed twice"
warnings from rpmbuild. These could be fixed by removing these lines from the
%files list:

  %{python_sitearch}/twisted/manhole/ui/*.py*
  %{python_sitearch}/twisted/manhole/ui/*.glade
  %{python_sitearch}/twisted/manhole/ui/gtkrc
  %{python_sitearch}/twisted/persisted/journal/

  However, the whole %{python_sitearch} %files tree could be simplified down to:

  %dir %{python_sitearch}/twisted/
  %{python_sitearch}/twisted/*.py*
  %{python_sitearch}/twisted/application/
  %{python_sitearch}/twisted/cred/
  %{python_sitearch}/twisted/enterprise/
  %{python_sitearch}/twisted/internet/
  %{python_sitearch}/twisted/manhole/
  %{python_sitearch}/twisted/persisted/
  %dir %{python_sitearch}/twisted/plugins/
  %{python_sitearch}/twisted/plugins/*.py*
  %ghost %{python_sitearch}/twisted/plugins/dropin.cache
  %{python_sitearch}/twisted/protocols/
  %{python_sitearch}/twisted/python/
  %{python_sitearch}/twisted/scripts/
  %{python_sitearch}/twisted/spread/
  %{python_sitearch}/twisted/tap/
  %{python_sitearch}/twisted/test/
  %{python_sitearch}/twisted/trial/

2. There is lots of unpackaged documentation in the doc/ directory. How about a
separate -doc subpackage?

3. rpmlint output:

  E: python-twisted-core non-executable-script
/usr/lib64/python2.4/site-packages/twisted/internet/glib2reactor.py 0644
  W: python-twisted-core devel-file-in-non-devel-package
/usr/lib64/python2.4/site-packages/twisted/spread/cBanana.c
  W: python-twisted-core devel-file-in-non-devel-package
/usr/lib64/python2.4/site-packages/twisted/protocols/_c_urlarg.c
  E: python-twisted-core non-executable-script
/usr/lib64/python2.4/site-packages/twisted/trial/test/scripttest.py 0644
  E: python-twisted-core script-without-shebang
/usr/share/zsh/site-functions/_twisted_zsh_stub

  The non-executable-script errors could be fixed by quick couple of seds in %prep:

  sed -i -e '/^#! *\/usr\/bin\/python/d' twisted/internet/glib2reactor.py
  sed -i -e '/^#!\/bin\/python/d'        twisted/trial/test/scripttest.py

  The script-without-shebang error could be fixed by installing
/usr/share/zsh/site-functions/_twisted_zsh_stub with mode 644

  Not sure about the devel-file-in-non-devel-package warning; are these devel
files or are they needed at runtime for something? Are they needed at all?

4. Strictly speaking the package should have a dependency on zsh for the
ownership of the %{_datadir}/zsh/site-functions directory. I guess the "right"
think to do would be to break out a separate -zsh subpackage for it, but that
seems rather like overkill for one tiny file. Thoughts?

5. I think the URL for this package should be
http://twistedmatrix.com/trac/wiki/TwistedCore, with
http://www.twistedmatrix.com/ reserved for the python-twisted metapackage.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.